Make check_column_name_contract case insensitive for pattern and datatype #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 47 47
Lines 2330 2330
Branches 309 309
=======================================
Hits 2294 2294
Misses 21 21
Partials 15 15 ☔ View full report in Codecov by Sentry. |
|
Thank you for contributing @samkessaram |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make check_column_name_contract case insensitive for pattern and datatype. We use Snowflake and were finding that the check_column_name_contract hook wasn't working as expected with the following args:
[--pattern, "(is|has)_.*", --dtype, boolean]What was happening was that the catalog.json file was uppercasing the column names and datatypes, so when dbt-checkpoint was comparing the catalog to the config, nothing was being caught. There are workarounds by adding additional hooks and using more extensive regexes, but this caused a headache and it seems like dbt-checkpoint should be able to handle this.