-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --allow-extra-keys to check-source-has-meta-keys #176
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=========================================
+ Coverage 0 96.32% +96.32%
=========================================
Files 0 51 +51
Lines 0 2505 +2505
Branches 0 332 +332
=========================================
+ Hits 0 2413 +2413
- Misses 0 72 +72
- Partials 0 20 +20 ☔ View full report in Codecov by Sentry. |
) | ||
|
||
|
||
def has_meta_key( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function seems pretty similar to what we need to do with models, sources, and exposures. Did you think about generalizing and then adding this functionality as a util?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JFrackson, sources and exposures ones are in part similar, though sources contain a schema+table meta union.
Modelshas_meta_key
is almost entirely different IMO
…allow-extra-keys-in-sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.