Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub action #187

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Fix GitHub action #187

merged 6 commits into from
Mar 6, 2024

Conversation

BAntonellini
Copy link
Collaborator

@BAntonellini BAntonellini commented Feb 9, 2024

EDIT: See below

@BAntonellini BAntonellini changed the title Fix GitHub action Deprecate GitHub action Feb 9, 2024
Copy link
Contributor

@alfredodimassimo alfredodimassimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BAntonellini BAntonellini marked this pull request as ready for review February 12, 2024 21:32
@BAntonellini
Copy link
Collaborator Author

@alfredodimassimo we opted for creating a new one: https://github.com/dbt-checkpoint/action

This new action, which is now apart from dbt-checkpoint's main repo, receives 3 optional arguments. See URL above for details.

The main benefit over running pre-commit's default action, is that with dbt-checkpoint's we can specify dbt version and dbt-adapter on the fly.

@BAntonellini BAntonellini changed the title Deprecate GitHub action Fix GitHub action Feb 13, 2024
Copy link
Contributor

@ronak-datatonic ronak-datatonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BAntonellini BAntonellini merged commit 3165412 into main Mar 6, 2024
7 checks passed
@BAntonellini BAntonellini deleted the fix-github-action branch March 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants