Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support yml suffix (without A) in dbt-checkpoint config file #190

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

BAntonellini
Copy link
Collaborator

No description provided.

Copy link
Contributor

@ronak-datatonic ronak-datatonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide test evidence of a mock yaml file with and without the "a"?

@BAntonellini BAntonellini requested review from ronak-datatonic and removed request for alfredodimassimo March 4, 2024 14:26
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.93%. Comparing base (739d419) to head (b7ea885).

Files Patch % Lines
dbt_checkpoint/utils.py 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   97.92%   97.93%           
=======================================
  Files          50       50           
  Lines        2462     2466    +4     
  Branches      327      329    +2     
=======================================
+ Hits         2411     2415    +4     
+ Misses         32       31    -1     
- Partials       19       20    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ronak-datatonic ronak-datatonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test, lgtm!

@BAntonellini BAntonellini merged commit 8248555 into main Mar 5, 2024
7 checks passed
@BAntonellini BAntonellini deleted the fix/dbt-checkpoint-config-file-suffix branch March 5, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants