Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix-192: Applied lower() to schema_cols #197

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

ronak-datatonic
Copy link
Contributor

This PR provides a fix the bug #192. It applies lower() to schema_cols.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (154fee6) to head (3ee92a3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          55       55           
  Lines        2592     2592           
  Branches      349      349           
=======================================
  Hits         2512     2512           
  Misses         59       59           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronak-datatonic ronak-datatonic changed the title Applied lower() to schema_cols Bggfix-192: Applied lower() to schema_cols Mar 20, 2024
@ronak-datatonic ronak-datatonic changed the title Bggfix-192: Applied lower() to schema_cols Bugfix-192: Applied lower() to schema_cols Mar 20, 2024
Copy link
Collaborator

@BAntonellini BAntonellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BAntonellini BAntonellini merged commit a8aab0b into main Mar 28, 2024
7 checks passed
@BAntonellini BAntonellini deleted the bugfix-192/check_source_has_all_columns branch March 28, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants