-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update regex_comments string in check-script-has-no-table-name #47
Conversation
hey @tomsej wanted to call your attention to this, which solves what may also be a blocker for some other folks trying to upgrade to v1.0.0 |
Sorry @neddonaldson . I was solving some family issues. Will look into this tomorrow! |
@tomsej no need to apologize! Appreciate you taking a look |
Hi @neddonaldson, thank you for this PR! It is tricky! But your regex is much better than mine. Unfortunately
It is returning "/**/". Think fixing the test is enough since |
@tomsej ready for your eyes again. Just added an option for the test to pass with "/**/" per your note that "it does not matter if it is returning blank comments". Passed locally but it doesn't look like I can run workflows to check in github actions |
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 1956 1956
Branches 256 258 +2
=========================================
Hits 1956 1956
Continue to review full report at Codecov.
|
Thank you @neddonaldson looks good! Hope new version will be released soon |
fixes #46