Optionally allow extra keys in check-model-has-meta-keys #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
check-model-has-meta-keys
does not allow the model to have any other meta keys other than the ones required.This PR introduces an optional argument to allow for it.
Our use case is that we need a check that checks that all models have, at a minimum, an "owner" meta key, while still allowing other meta keys (PII, etc).
The extra parameter has a
False
default value, meaning it is backward compatible with everyone that is using the check today.More context on: #60