Skip to content

Commit

Permalink
Fix deprecated GitHub action commands (#45)
Browse files Browse the repository at this point in the history
* Formatting workflows files

* Fix deprecated set-output commands

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
  • Loading branch information
kevinneville and emmyoop committed Jan 17, 2023
1 parent 7920b75 commit b37524a
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 22 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/changelog-existence.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:
runs-on: ubuntu-latest

steps:

- name: "[DEBUG] - Print Inputs"
shell: bash
id: echo_inputs
Expand Down Expand Up @@ -76,7 +75,7 @@ jobs:
id: changelog_comment
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'github-actions[bot]'
comment-author: "github-actions[bot]"
body-includes: ${{ inputs.changelog_comment }}

- name: Set if comment already exists
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/core-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# **when?**
# Every ~hour, on PR, or manually.


name: core-triage

on:
Expand All @@ -32,14 +31,13 @@ jobs:
add-items-to-project:
runs-on: ubuntu-latest
steps:

- name: check out repo
uses: actions/checkout@v2

- name: setup python
uses: actions/setup-python@v2
with:
python-version: '3.10'
python-version: "3.10"

- name: pip installs
run: pip install -r requirements.txt
Expand All @@ -50,4 +48,3 @@ jobs:
working-directory: scripts/core-triage
env:
GH_TOKEN: ${{ secrets.VARIABLE_CORE_TRIAGE_ONLY }}

1 change: 0 additions & 1 deletion .github/workflows/jira-transition-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,3 @@ jobs:
JIRA_BASE_URL: ${{ secrets.JIRA_BASE_URL }}
JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }}
JIRA_API_TOKEN: ${{ secrets.JIRA_API_TOKEN }}

5 changes: 2 additions & 3 deletions .github/workflows/replace-label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
# uses: dbt-labs/actions/.github/workflows/triage-labels.yml@main
# secrets: inherit


name: Replace Issue Label

on:
Expand All @@ -49,7 +48,7 @@ defaults:
permissions:
issues: write

jobs:
jobs:
triage_label:
if: contains(github.event.issue.labels.*.name, inputs.original_label)
runs-on: ubuntu-latest
Expand All @@ -62,7 +61,7 @@ jobs:
echo "all variables defined as inputs"
echo "original_label: ${{ inputs.original_label }}"
echo "new_label: ${{ inputs.new_label }}"
- name: switch labels
id: switch_labels
run: |
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/version-bump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ on:
workflow_call:
inputs:
version_number:
description: 'The version number to bump to (ex. 1.2.0, 1.3.0b1)'
type: string
required: true
description: "The version number to bump to (ex. 1.2.0, 1.3.0b1)"
type: string
required: true

jobs:
bump:
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Set branch value
id: variables
run: |
echo "::set-output name=BRANCH_NAME::prep-release/${{ github.event.inputs.version_number }}_$GITHUB_RUN_ID"
echo "BRANCH_NAME=prep-release/${{ github.event.inputs.version_number }}_$GITHUB_RUN_ID" >> $GITHUB_OUTPUT
- name: Create PR branch
run: |
Expand Down Expand Up @@ -110,18 +110,18 @@ jobs:
- name: Commit version bump to branch
uses: EndBug/add-and-commit@v7
with:
author_name: 'Github Build Bot'
author_email: 'buildbot@fishtownanalytics.com'
message: 'Bumping version to ${{ github.event.inputs.version_number }} and generate CHANGELOG'
branch: '${{ steps.variables.outputs.BRANCH_NAME }}'
push: 'origin origin/${{ steps.variables.outputs.BRANCH_NAME }}'
author_name: "Github Build Bot"
author_email: "buildbot@fishtownanalytics.com"
message: "Bumping version to ${{ github.event.inputs.version_number }} and generate CHANGELOG"
branch: "${{ steps.variables.outputs.BRANCH_NAME }}"
push: "origin origin/${{ steps.variables.outputs.BRANCH_NAME }}"

- name: Create Pull Request
uses: peter-evans/create-pull-request@v3
with:
author: 'Github Build Bot <buildbot@fishtownanalytics.com>'
author: "Github Build Bot <buildbot@fishtownanalytics.com>"
base: ${{github.ref}}
title: 'Bumping version to ${{ github.event.inputs.version_number }} and generate changelog'
branch: '${{ steps.variables.outputs.BRANCH_NAME }}'
title: "Bumping version to ${{ github.event.inputs.version_number }} and generate changelog"
branch: "${{ steps.variables.outputs.BRANCH_NAME }}"
labels: |
Skip Changelog

0 comments on commit b37524a

Please sign in to comment.