Please do not use using

[epapineau]

Add guidance to the style guide for writing explicit join instructions with an on clause instead of implicit join instructions with a using clause.

The data team has experienced drift in our internal project based on personal preferences and would like to add this rule to the style guide to use for reference when we request changes on a using clause.

[patkearns10]

I was gonna say, I thought this was always in the style guide! https://github.com/dbt-labs/corp/pull/58/files

[epapineau]

@patkearns10 I thought it was as well ??

[bthomson22]

It definitely was! I believe it was removed when it was determined that Snowflake resolved the bugs around using - that being said, I'm a-ok with being explicit about not using using, since it is harder to comprehend, and can theoretically cause errors in multi-join CTEs.

[bthomson22]

That was meant to be an approval

[b-per]

We actually removed this explicitly when we reviewed the guide a few months back. I think that the initial comment was that there was performance reason with using which don't exist anymore.

In my mind, using is great because it forces you to name your columns correctly upstream.

[patkearns10]

This is my gripe with using, if you do not fully qualify your tables
https://getdbt.slack.com/archives/CBSQTAPLG/p1626478828173900?thread_ts=1626439665.129500&cid=CBSQTAPLG