Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving message description for compile error in get_fixtu… #203

Conversation

AlejandroBlanco2001
Copy link
Contributor

@AlejandroBlanco2001 AlejandroBlanco2001 commented May 11, 2024

resolves dbt-labs/dbt-core#10014

Problem

When running SQL unit tests, when a relation does not exist (or the model does not exist), a compilation error is thrown which does not give any idea why this is happening.

Solution

Therefore, a small new feature is added where the error message is improved to give a better idea on how to resolve the error when running the test.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@AlejandroBlanco2001 AlejandroBlanco2001 requested a review from a team as a code owner May 11, 2024 06:10
Copy link

cla-bot bot commented May 11, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @AlejandroBlanco2001

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@AlejandroBlanco2001 AlejandroBlanco2001 changed the title feature: improving message description for compile error in get_fixtu… Improving message description for compile error in get_fixtu… May 11, 2024
@AlejandroBlanco2001
Copy link
Contributor Author

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @AlejandroBlanco2001

@cla-bot cla-bot bot added the cla:yes label May 11, 2024
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

note: this is simply an update to the language in an exception we're raising, to provide the end user with greater clarity on the error :)

@colin-rogers-dbt colin-rogers-dbt merged commit 2e7d04c into dbt-labs:main May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] unit testing: dbt should tell me why it couldn't get columns (the model doesn't yet exist)
5 participants