Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_catalog_for_single_relation a concrete method in BaseAdapter #240

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Jun 19, 2024

Problem

dbt-adapters==1.3.0 had to be yanked because adapters didn't implement the new abstract method get_catalog_for_single_relation.
This method should be opt-in, so adapters shouldn't need to implement this.

Solution

Make the get_catalog_for_single_relation concrete in BaseAdapter so adapters can default to this implementation.
Sample PR with passing tests in dbt-bigquery that has not implemented this capability: dbt-labs/dbt-bigquery#1262

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@aranke aranke requested a review from a team as a code owner June 19, 2024 13:39
@cla-bot cla-bot bot added the cla:yes label Jun 19, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare merged commit 46e470c into main Jun 19, 2024
15 of 17 checks passed
@mikealfare mikealfare deleted the gcfsr_concrete branch June 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants