Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/decouple adapters from core #1026

Merged
merged 15 commits into from Jan 10, 2024
Merged

feature/decouple adapters from core #1026

merged 15 commits into from Jan 10, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Nov 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review December 19, 2023 20:51
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner December 19, 2023 20:51
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 21, 2023
Merged
5 tasks
mikealfare
mikealfare reviewed Jan 5, 2024
View reviewed changes
dbt/adapters/bigquery/impl.py Show resolved Hide resolved
dbt/adapters/bigquery/impl.py Show resolved Hide resolved
dbt/adapters/bigquery/impl.py Show resolved Hide resolved
dbt/adapters/bigquery/impl.py Show resolved Hide resolved
dbt/adapters/bigquery/relation_configs/_base.py Show resolved Hide resolved
dbt/adapters/bigquery/relation_configs/_cluster.py Show resolved Hide resolved
dbt/adapters/bigquery/relation_configs/_materialized_view.py Outdated Show resolved Hide resolved
@colin-rogers-dbt colin-rogers-dbt self-assigned this Jan 9, 2024
@mikealfare mikealfare merged commit f2804c0 into main Jan 10, 2024
15 checks passed
@mikealfare mikealfare deleted the feature/decouple-adapters-from-core branch January 10, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees

@colin-rogers-dbt colin-rogers-dbt

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colin-rogers-dbt @mikealfare