Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ddtrace dependency range #1141

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Test ddtrace dependency range #1141

merged 2 commits into from
Mar 19, 2024

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Mar 19, 2024

resolves #1142
docs dbt-labs/docs.getdbt.com/#

Problem

A change in ddtrace or a upper dependency around helpconfig seems to be causing failures in adapters. setting bounds to be in the 2.3.x range seems to get us passing.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Mar 19, 2024
@cla-bot cla-bot bot added the cla:yes label Mar 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

1 similar comment
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare merged commit faf1a7f into main Mar 19, 2024
26 checks passed
@mikealfare mikealfare deleted the mcknight/test-ddtrace branch March 19, 2024 20:39
@colin-rogers-dbt colin-rogers-dbt added backport 1.2.latest Tag for PR to be backported to the 1.2.latest branch backport 1.3.latest Tag for PR to be backported to the 1.3.latest branch backport 1.4.latest Tag for PR to be backported to the 1.4.latest branch backport 1.5.latest Tag for PR to be backported to the 1.5.latest branch backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Mar 27, 2024
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-1141-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faf1a7f5bf46103c42cd598497147d4b4e196b0b
# Push it to GitHub
git push --set-upstream origin backport-1141-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-1141-to-1.5.latest.

Copy link
Contributor

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-1141-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faf1a7f5bf46103c42cd598497147d4b4e196b0b
# Push it to GitHub
git push --set-upstream origin backport-1141-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-1141-to-1.2.latest.

Copy link
Contributor

The backport to 1.3.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3.latest 1.3.latest
# Navigate to the new working tree
cd .worktrees/backport-1.3.latest
# Create a new branch
git switch --create backport-1141-to-1.3.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faf1a7f5bf46103c42cd598497147d4b4e196b0b
# Push it to GitHub
git push --set-upstream origin backport-1141-to-1.3.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3.latest

Then, create a pull request where the base branch is 1.3.latest and the compare/head branch is backport-1141-to-1.3.latest.

Copy link
Contributor

The backport to 1.4.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-1141-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faf1a7f5bf46103c42cd598497147d4b4e196b0b
# Push it to GitHub
git push --set-upstream origin backport-1141-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest

Then, create a pull request where the base branch is 1.4.latest and the compare/head branch is backport-1141-to-1.4.latest.

Copy link
Contributor

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-1141-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faf1a7f5bf46103c42cd598497147d4b4e196b0b
# Push it to GitHub
git push --set-upstream origin backport-1141-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-1141-to-1.7.latest.

Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-1141-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faf1a7f5bf46103c42cd598497147d4b4e196b0b
# Push it to GitHub
git push --set-upstream origin backport-1141-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-1141-to-1.6.latest.

mikealfare pushed a commit that referenced this pull request Apr 1, 2024
* set bounds for ddtrace due to tests failing

* hard pin ddtrace, create changelog

(cherry picked from commit faf1a7f)
mikealfare pushed a commit that referenced this pull request Apr 1, 2024
* set bounds for ddtrace due to tests failing

* hard pin ddtrace, create changelog

(cherry picked from commit faf1a7f)
mikealfare added a commit that referenced this pull request Apr 1, 2024
* set bounds for ddtrace due to tests failing

* hard pin ddtrace, create changelog

(cherry picked from commit faf1a7f)
mikealfare added a commit that referenced this pull request Apr 1, 2024
* set bounds for ddtrace due to tests failing

* hard pin ddtrace, create changelog

(cherry picked from commit faf1a7f)
mikealfare added a commit that referenced this pull request Apr 1, 2024
* Test ddtrace dependency range (#1141)
* set bounds for ddtrace due to tests failing
* hard pin ddtrace, create changelog
* pin pytest to minor

(cherry picked from commit faf1a7f)

---------

Co-authored-by: Matthew McKnight <91097623+mcknight-42@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Apr 1, 2024
* Test ddtrace dependency range (#1165)
* set bounds for ddtrace due to tests failing
* hard pin ddtrace, create changelog
* pin pytest to minor

(cherry picked from commit faf1a7f)

---------

Co-authored-by: Matthew McKnight <91097623+mcknight-42@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.2.latest Tag for PR to be backported to the 1.2.latest branch backport 1.3.latest Tag for PR to be backported to the 1.3.latest branch backport 1.4.latest Tag for PR to be backported to the 1.4.latest branch backport 1.5.latest Tag for PR to be backported to the 1.5.latest branch backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]hard pin ddtrace version to 2.3
3 participants