Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/enable serverless #303

Merged
merged 7 commits into from
Sep 12, 2022
Merged

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Sep 9, 2022

resolves #248

Description

Add serverless Dataproc submission method and re-enable python model tests

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to take the branch out of dev-requirements.txt :)

@ChenyuLInx
Copy link
Contributor Author

Don't forget to take the branch out of dev-requirements.txt :)

@gshank Yea, I am gonna make sure the tests all pass then update and merge in sequence

@ChenyuLInx ChenyuLInx merged commit 84c20fc into main Sep 12, 2022
@ChenyuLInx ChenyuLInx deleted the enhancement/enable_serverless branch September 12, 2022 18:33
@dbeatty10
Copy link
Contributor

It looks like dev-requirements.txt got merged on accident?

git+https://github.com/dbt-labs/dbt-core.git@enhancement/python_submission_helper#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@enhancement/python_submission_helper#egg=dbt-tests-adapter&subdirectory=tests/adapter

@ChenyuLInx
Copy link
Contributor Author

Yes, fixing now

@jtcohen6 jtcohen6 mentioned this pull request Sep 16, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-980] [feature] Use dataproc serverless instead of dataproc cluster
4 participants