Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery Anonymous Authentication #692

Closed
wants to merge 3 commits into from
Closed

BigQuery Anonymous Authentication #692

wants to merge 3 commits into from

Conversation

kpolley
Copy link

@kpolley kpolley commented May 2, 2023

Description

Adds the option to authenticate to BigQuery using anonymous credentials. Useful for public datasets and unit testing. Will help solve for #358

Checklist

@kpolley kpolley requested a review from a team as a code owner May 2, 2023 21:57
@kpolley kpolley requested a review from nssalian May 2, 2023 21:57
@cla-bot cla-bot bot added the cla:yes label May 2, 2023
Copy link
Contributor

@nssalian nssalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR, @kpolley. The change looks good.
Do you think we could add a small unit test - in either conftest or test_bigquery_adapter?

@kpolley
Copy link
Author

kpolley commented May 16, 2023

Thanks for opening the PR, @kpolley. The change looks good. Do you think we could add a small unit test - in either conftest or test_bigquery_adapter?

Added a unit test in test_bigquery_adapter. Let me know if there's anything else and feel free to modify the PR as well.

Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 13, 2023
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants