Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbt show tests #927

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Add dbt show tests #927

merged 6 commits into from
Sep 28, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 18, 2023

resolves #940

docs dbt-labs/docs.getdbt.com/# N/A

Adding tests for dbt show introduced in dbt-labs/dbt-core#8641

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 18, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@8496/limit-in-show-query#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@8496/limit-in-show-query#egg=dbt-tests-adapter&subdirectory=tests/adapter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will undo before merging.

@MichelleArk MichelleArk marked this pull request as ready for review September 25, 2023 14:04
@MichelleArk MichelleArk requested a review from a team as a code owner September 25, 2023 14:04
@colin-rogers-dbt colin-rogers-dbt merged commit 0fe8afc into main Sep 28, 2023
25 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the test-limit-in-show-sql branch September 28, 2023 18:32
@colin-rogers-dbt colin-rogers-dbt restored the test-limit-in-show-sql branch September 28, 2023 18:32
McKnight-42 added a commit that referenced this pull request Sep 28, 2023
@McKnight-42 McKnight-42 added backport 1.5.latest Tag for PR to be backported to the 1.5.latest branch backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch labels Sep 28, 2023
@github-actions
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-927-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0fe8afc105ed196bcd201c0c487f03e2f93aba8b
# Push it to GitHub
git push --set-upstream origin backport-927-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-927-to-1.6.latest.

@github-actions
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-927-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0fe8afc105ed196bcd201c0c487f03e2f93aba8b
# Push it to GitHub
git push --set-upstream origin backport-927-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-927-to-1.5.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.5.latest Tag for PR to be backported to the 1.5.latest branch backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-915] [Tests] Add tests for inlined limit + sql_header in dbt show query
3 participants