Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper bound to pandas whenever it is a transitive dependency #125

Open
dbeatty10 opened this issue Feb 1, 2024 · 0 comments
Open

Add upper bound to pandas whenever it is a transitive dependency #125

dbeatty10 opened this issue Feb 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dbeatty10
Copy link

Proposal

To fully mitigate the blast radius reported in dbt-labs/dbt-core#9420, we should do something similar to #122 for all requirements.txt files that transitively include pandas.

More detail

pandas 2.2.0 has some breaking changes versus pandas 2.1.4.

These breaking changes can surface to users of dbt-databricks because pandas is a transitive dependency, and this was reported in dbt-labs/dbt-core#9420.

In order to mitigate the effects of dbt-labs/dbt-core#9420, we did #122 for dbt 1.5, 1.6, and 1.7.

We should do the same going back at least to dbt 1.3 9 (and maybe further).

The buggy behavior could theoretically go back at least to 1.3 since that is when dbt began enabling python models.

But there could be a transitive dependency on pandas via databricks-sql-connector that goes back further than that -- it just might not actually have an effect on dbt.

@dbeatty10 dbeatty10 added the bug Something isn't working label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant