Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bounds to pandas for 1.7 #122

Merged
merged 2 commits into from
Jan 23, 2024
Merged

add bounds to pandas for 1.7 #122

merged 2 commits into from
Jan 23, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

  • add upper/lower bounds to pandas import in v1.7.latest.requirements.txt

Copy link

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as a mitigation of this issue: dbt-labs/dbt-core#9420 (comment)

@dbeatty10
Copy link

@colin-rogers-dbt the issue with pandas==2.2.0 could affect any version of dbt-databricks in dbt Cloud (since it has a transitive dependency on pandas).

What are your thoughts about adding this same upper bound for all available bundles (1.6, 1.5, etc.)?

@colin-rogers-dbt colin-rogers-dbt merged commit 575734f into main Jan 23, 2024
7 of 8 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the addBoundsToPandas17 branch January 23, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants