Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_sql_header works well with 'table', but not 'incremental' #2136

Closed
4 tasks
fhoffa opened this issue Feb 14, 2020 · 2 comments · Fixed by #2200
Closed
4 tasks

set_sql_header works well with 'table', but not 'incremental' #2136

fhoffa opened this issue Feb 14, 2020 · 2 comments · Fixed by #2200
Assignees
Labels
bigquery bug Something isn't working

Comments

@fhoffa
Copy link

fhoffa commented Feb 14, 2020

Describe the bug

This test fails when you change 'table' for 'incremental':

test/integration/022_bigquery_test/models/sql_header_model.sql

Steps To Reproduce

  1. Change 'table' to 'incremental' in sql_header_model.sql
  2. dbt run works well the first time (creates the table)
  3. dbt run fails the next time (when doing incremental)

Expected behavior

The incremental run should bring the same headers - the model will again need the temporal function.

Screenshots and log output

"Function not found: yes_no_to_boolean at [14:8]"

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • [x ] bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:
0.15.2

@fhoffa fhoffa added bug Something isn't working triage labels Feb 14, 2020
@drewbanin drewbanin removed the triage label Feb 14, 2020
@drewbanin drewbanin added bigquery good_first_issue Straightforward + self-contained changes, good for new contributors! labels Feb 18, 2020
@drewbanin
Copy link
Contributor

Thanks for the report @fhoffa - we'll check it out!

@drewbanin
Copy link
Contributor

@fhoffa see the fix for this here: #2200

We're in the late phases of the 0.16.0 release and we've generally locked down PRs with the exception of any regressions discovered during the release candidate phase. I think we should target an 0.16.1 bugfix release for this PR. Just wanted to give you a heads up!

@drewbanin drewbanin removed the good_first_issue Straightforward + self-contained changes, good for new contributors! label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants