Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partitions to bq AdapterSpecificConfigs #2256

Closed
jtcohen6 opened this issue Mar 27, 2020 · 3 comments
Closed

Add partitions to bq AdapterSpecificConfigs #2256

jtcohen6 opened this issue Mar 27, 2020 · 3 comments
Labels
bigquery bug Something isn't working
Milestone
0.16.1

Comments

@jtcohen6
Copy link
Contributor

Describe the feature

  • Allow the user to define partitions in dbt_project.yml. This is a necessary config if the user wants to run incremental models with the insert_overwrite strategy for a static (user-defined) set of partitions
  • Adding/overriding partitions in dbt_project.yml is the only way to adjust behavior for models imported from a package (e.g. Snowplow)

Additional context

This is functionality we added in #2198, but forgot to add partitions to AdapterSpecificConfigs in dbt-bigquery

Who will this benefit?

BigQuery users
@jtcohen6 jtcohen6 added bug Something isn't working bigquery labels Mar 27, 2020
@drewbanin drewbanin added this to the Octavius Catto milestone Mar 27, 2020
@drewbanin
Copy link
Contributor

Cool idea @jtcohen6 - let's do it!

@beckjake
Copy link
Contributor

We should do this for 0.16.1, right?

@drewbanin drewbanin modified the milestones: Octavius Catto, 0.16.1 Mar 27, 2020
@jtcohen6 jtcohen6 mentioned this issue Mar 27, 2020
Merged
@beckjake beckjake mentioned this issue Mar 31, 2020
Merged
4 tasks
beckjake added a commit that referenced this issue Apr 1, 2020
@beckjake
Merge pull request #2280 from fishtown-analytics/fix/add-partitions-b…
ff0e955 
…q-config

Add "partitions" to the adapter specific config (#2256)
@drewbanin
Copy link
Contributor

closed by #2280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bigquery bug Something isn't working
Projects
None yet
Milestone
0.16.1
Development

No branches or pull requests
3 participants
@beckjake @drewbanin @jtcohen6