Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-464] [Feature] improve GitHub Git Blame UI by ignoring commits auto-format #5004

Closed
1 task done
dataders opened this issue Apr 6, 2022 · 4 comments
Closed
1 task done
Labels
enhancement New feature or request tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@dataders
Copy link
Contributor

dataders commented Apr 6, 2022

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

I was just informed via popup that Ignoring commits in blame view is now in public preview on GitHub.

This came up as I was trying to debug this Slack issue for an adapter maintainer. Where #4697 was in the way of me finding out what had recently changed here:

return "{}{}.{}.{}{}{}".format(
matcher, self.major, self.minor, self.patch, prerelease, build
)

Describe alternatives you've considered

I click the previous commit button twice to see the "actual" last time it changed?

Who will this benefit?

Anyone who looks at Git blame of dbt-core source code in GitHub

Are you interested in contributing this feature?

sure!

Anything else?

Looks like we'd just have to fetch the collect the hashes of any "re-formatting" commit and put them into a .git-blame-ignore-revs file

@dataders dataders added enhancement New feature or request triage labels Apr 6, 2022
@github-actions github-actions bot changed the title [Feature] improve GitHub Git Blame UI by ignoring commits auto-format [CT-464] [Feature] improve GitHub Git Blame UI by ignoring commits auto-format Apr 6, 2022
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed triage labels Apr 7, 2022
@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 7, 2022

Looks like we'd just have to fetch the collect the hashes of any "re-formatting" commit and put them into a .git-blame-ignore-revs file

Woah!! Heck yeah, let's do it

Tagging this one tech_debt, though it's almost more like oss_debt/maintainer_debt. No doubt it will be of big benefit to the folks on our team, too

@iknox-fa
Copy link
Contributor

iknox-fa commented Apr 8, 2022

What? My re-formatting will no longer hide the world in a blanket of Reformat core commits? gasp
Thanks for bringing this to our attention, I'll get a PR out for it shortly!

@iknox-fa
Copy link
Contributor

iknox-fa commented Apr 8, 2022

#5019

@jtcohen6
Copy link
Contributor

resolved by #5019!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

3 participants