Reformat core [CT-104 CT-105] #4697

iknox-fa · 2022-02-08T16:05:17Z

resolves #3195 and #3196 (CT-104, CT-105)

Description

The results of running the pre-commit code in this PR vs main.
Note that the commits were made using git-black and therefor maintain the correct history.

Checklist

I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have updated the CHANGELOG.md and added information about my change

empty automatic commit by git-black, original commits: d7ea364

…4322) automatic commit by git-black, original commits: d046ae0

for processing automatic commit by git-black, original commits: a83f00c

* Fix docs generation for cross-db sources in REDSHIFT RA3 node (#3408) * Fix docs generating for cross-db sources * Code reorganization * Code adjustments according to flake8 * Error message adjusted to be more precise * CHANGELOG update * add static analysis info to parsing data * update changelog * don't use `meta`! need better separation between dbt internal objects and external facing data. hacked an internal field on the manifest to save off this parsing info for the time being * fix partial parsing case Co-authored-by: kostek-pl <67253952+kostek-pl@users.noreply.github.com> automatic commit by git-black, original commits: 4d24656 a76ec42

actually fix static parser tracking automatic commit by git-black, original commits: 1c61bb1 21a7b71

automatic commit by git-black, original commits: b501f43

fix jinja sampling for static parser automatic commit by git-black, original commits: 21a7b71

automatic commit by git-black, original commits: 3944705

actually fix static parser tracking automatic commit by git-black, original commits: 1c61bb1

actually fix static parser tracking automatic commit by git-black, original commits: 1c61bb1 6925ceb

* add tracking event for full reparse reason * update changelog automatic commit by git-black, original commits: 2679792 c69f28e

- removed 3 new log call sites and replaced with structured logs - removed 2 unused struc logs automatic commit by git-black, original commits: 5cc8626

* add tracking event for full reparse reason * update changelog automatic commit by git-black, original commits: 2679792

report exception information. automatic commit by git-black, original commits: af16c74

automatic commit by git-black, original commits: aadf3c7

automatic commit by git-black, original commits: 052a306 98c015b

* Fix docs generation for cross-db sources in REDSHIFT RA3 node (#3408) * Fix docs generating for cross-db sources * Code reorganization * Code adjustments according to flake8 * Error message adjusted to be more precise * CHANGELOG update * add static analysis info to parsing data * update changelog * don't use `meta`! need better separation between dbt internal objects and external facing data. hacked an internal field on the manifest to save off this parsing info for the time being * fix partial parsing case Co-authored-by: kostek-pl <67253952+kostek-pl@users.noreply.github.com> automatic commit by git-black, original commits: 2cc0579 4d24656

automatic commit by git-black, original commits: 5e8ab9c af8622e

The alias name check is now tied to the behavior of adapter.Relation.create_from(...) Plugins that override the `include` of their relations will use whatever they render to for the check the actual exception-raising code gets the name that was compared instead of generating its own Finally, I added a reasonable fallback behavior since this method was exposed to the context automatic commit by git-black, original commits: 20c5c4c 5e8ab9c af8622e

automatic commit by git-black, original commits: e935439

automatic commit by git-black, original commits: 56ae206 8520ff3

Handle empty vars dict Check sources for unused configs - add a test Warn when dbt finds "vars" in "models", "seeds", etc blocks - add a test Clean up enabled/disabled code to share between sources and nodes - only log downstream tests at debug level when a source is disabled - include the offending project name in the v1 deprecation message - Fix tests that care about error messages, add new ones automatic commit by git-black, original commits: b8febdd c18b72b

automatic commit by git-black, original commits: 3d28b67

automatic commit by git-black, original commits: 3d28b67 d246bab

automatic commit by git-black, original commits: 10cd06f b030b4e

automatic commit by git-black, original commits: 10aded7

…egration test for checking case-insensitive extensions automatic commit by git-black, original commits: f9343c4

automatic commit by git-black, original commits: 1d91890

* Fix docs generation for cross-db sources in REDSHIFT RA3 node (#3408) * Fix docs generating for cross-db sources * Code reorganization * Code adjustments according to flake8 * Error message adjusted to be more precise * CHANGELOG update * add static analysis info to parsing data * update changelog * don't use `meta`! need better separation between dbt internal objects and external facing data. hacked an internal field on the manifest to save off this parsing info for the time being * fix partial parsing case Co-authored-by: kostek-pl <67253952+kostek-pl@users.noreply.github.com> automatic commit by git-black, original commits: 4d24656 7563b99 aadf3c7

automatic commit by git-black, original commits: 007cb45

iknox-fa · 2022-02-08T16:19:52Z

@leahwicz do you know if we can disable the CLA bot for this? Each commit is made as it's original committer, many of which pre-date the cla-bot.

cla-bot · 2022-02-08T16:43:00Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joel Labes, Jacob Beck.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-02-08T17:09:24Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joel Labes, Jacob Beck.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

leahwicz · 2022-02-10T01:54:32Z

@cla-bot check

cla-bot · 2022-02-10T01:54:34Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joel Labes, Jacob Beck.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-02-10T01:54:35Z

The cla-bot has been summoned, and re-checked this pull request!

leahwicz · 2022-02-10T01:55:56Z

@cla-bot check

cla-bot · 2022-02-10T01:55:58Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joel Labes, Jacob Beck.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-02-10T01:55:59Z

The cla-bot has been summoned, and re-checked this pull request!

leahwicz · 2022-02-10T01:56:57Z

@iknox-fa when you are ready to merge let me know and we can coordinate on the CLA check. We might have to remove it as required and then close/reopen the PR and then merge

cla-bot · 2022-02-10T15:54:28Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joel Labes, Jacob Beck.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-02-11T16:36:45Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Joel Labes, Jacob Beck.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

gshank and others added 30 commits February 8, 2022 09:55

[#3567] Fix partial parsing error with version key if previous file is

bc4ddae

empty automatic commit by git-black, original commits: d7ea364

[#4253] Support partial parsing of env_vars in metrics definitions (#…

619e946

…4322) automatic commit by git-black, original commits: d046ae0

[#3627] Improve findability of macro_patches, schedule right macro file

098d034

for processing automatic commit by git-black, original commits: a83f00c

Fix static parser tracking again (#4109)

b12bb67

actually fix static parser tracking automatic commit by git-black, original commits: 1c61bb1 21a7b71

add jinja sampling to stable static parser (#3970)

5da10a9

automatic commit by git-black, original commits: b501f43

Fix tracking bug for jinja sampling (#4048)

a945047

fix jinja sampling for static parser automatic commit by git-black, original commits: 21a7b71

add macro override detection for ref, source, and config for ModelParser

08ea52a

automatic commit by git-black, original commits: 3944705

Fix static parser tracking again (#4109)

e1ffb95

actually fix static parser tracking automatic commit by git-black, original commits: 1c61bb1

Fix static parser tracking again (#4109)

9c1ae98

actually fix static parser tracking automatic commit by git-black, original commits: 1c61bb1 6925ceb

Add tracking event for full re-parse reasoning (#3652)

104fd8e

* add tracking event for full reparse reason * update changelog automatic commit by git-black, original commits: 2679792 c69f28e

updates associated with merging main

d092ac7

- removed 3 new log call sites and replaced with structured logs - removed 2 unused struc logs automatic commit by git-black, original commits: 5cc8626

Add tracking event for full re-parse reasoning (#3652)

42d5106

* add tracking event for full reparse reason * update changelog automatic commit by git-black, original commits: 2679792

[#3725] Switch to full reparse on partial parsing exceptions. Log and

a85bff6

report exception information. automatic commit by git-black, original commits: af16c74

Do schema file parsing after parsing all other files

fa304d9

automatic commit by git-black, original commits: aadf3c7

[#3810] Skip partial parsing if certain macros have changed

11b2d89

automatic commit by git-black, original commits: 052a306 98c015b

flake8, pep8, unit tests

f0a2a65

automatic commit by git-black, original commits: 5e8ab9c af8622e

Follow Jeremy's wild speculation

a02f94b

automatic commit by git-black, original commits: e935439

reports -> exposures

9c1b5ea

automatic commit by git-black, original commits: 56ae206 8520ff3

[#3689] Fix filesystem searcher and tests that mock it (#4271)

7587e14

automatic commit by git-black, original commits: 3d28b67

[#3689] Fix filesystem searcher and tests that mock it (#4271)

db3f37a

automatic commit by git-black, original commits: 3d28b67 d246bab

PR feedback

e31cf7d

automatic commit by git-black, original commits: 10cd06f b030b4e

cleaned up exceptions

0135561

automatic commit by git-black, original commits: 10aded7

1. Add integration test for yaml schema extension warning. 2. Add int…

148e385

…egration test for checking case-insensitive extensions automatic commit by git-black, original commits: f9343c4

no more warnings for parse failures

4b91cdd

automatic commit by git-black, original commits: 1d91890

Addressed PR comments

797f8ce

automatic commit by git-black, original commits: 007cb45

iknox-fa requested a review from a team February 8, 2022 16:18

iknox-fa requested review from a team and leahwicz as code owners February 8, 2022 16:18

update flake8 warnings

fb2edf9

more tox tweaks for flake8/black compatibility

1514def

Type error fixes and ignores

6c708b1

leahwicz approved these changes Feb 11, 2022

View reviewed changes

iknox-fa added 2 commits February 11, 2022 10:33

merge main

037b3c3

merge main formatting

8854d2f

iknox-fa merged commit 43e3fc2 into main Feb 11, 2022

iknox-fa deleted the reformat_core branch February 11, 2022 18:17

dataders mentioned this pull request Apr 6, 2022

[CT-464] [Feature] improve GitHub Git Blame UI by ignoring commits auto-format #5004

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reformat core [CT-104 CT-105] #4697

Reformat core [CT-104 CT-105] #4697

iknox-fa commented Feb 8, 2022 •

edited

Loading

iknox-fa commented Feb 8, 2022

cla-bot bot commented Feb 8, 2022

cla-bot bot commented Feb 8, 2022

leahwicz commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

leahwicz commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

leahwicz commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

cla-bot bot commented Feb 11, 2022

Reformat core [CT-104 CT-105] #4697

Reformat core [CT-104 CT-105] #4697

Conversation

iknox-fa commented Feb 8, 2022 • edited Loading

Description

Checklist

iknox-fa commented Feb 8, 2022

cla-bot bot commented Feb 8, 2022

cla-bot bot commented Feb 8, 2022

leahwicz commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

leahwicz commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

leahwicz commented Feb 10, 2022

cla-bot bot commented Feb 10, 2022

cla-bot bot commented Feb 11, 2022

iknox-fa commented Feb 8, 2022 •

edited

Loading