Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-781] Bump manifest schema to v6 for v1.2 #5417

Closed
jtcohen6 opened this issue Jun 28, 2022 · 4 comments
Closed

[CT-781] Bump manifest schema to v6 for v1.2 #5417

jtcohen6 opened this issue Jun 28, 2022 · 4 comments
Milestone

Comments

@jtcohen6
Copy link
Contributor

v1.2 will include a schema change for manifest.json, with the addition of the grants: {} default config. We'll need to update, document v6, and add/declare backwards compatibility (per #5346):

@classmethod
def compatible_previous_versions(self):
return [("manifest", 4)]

As I've said many many times before (in #4617 as elsewhere):

I'm interested in any small, tactical lifts we can make so that we're not bumping the manifest schema version in every single new minor version. At the same time, we're eager to provide other interfaces into manifest information, over which we have more control

Given that config can accept any values, it probably makes more sense to treat this in our JSONSchema as a dict[str, Any], rather than inferring its defaults from the node config classes.

The ability to declare backwards compatibility does remove this as an issue for most end users, but it remains true that we're creating unneeded manual work for metadata consumers.

This will also require updates to:

@jtcohen6 jtcohen6 added this to the v1.2 milestone Jun 28, 2022
@github-actions github-actions bot changed the title Bump manifest schema to v6 for v1.2 [CT-781] Bump manifest schema to v6 for v1.2 Jun 28, 2022
@leahwicz
Copy link
Contributor

AC:

  1. bump manifest to v6 in Core
  2. pushing the change into the schemas repo
  3. update docs

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Jul 5, 2022

Issue for updating docs: dbt-labs/docs.getdbt.com#1667

@emmyoop
Copy link
Member

emmyoop commented Jul 5, 2022

compatible_previous_versions was updated as part of #5027.

@jtcohen6
Copy link
Contributor Author

I think this one is resolved! We have a separate issue to track the docs update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants