Bumping manifest version to v6 #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
jtcohen6
reviewed
Jul 5, 2022
There was a problem hiding this comment.
FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/dbt-core/dbt-core/schemas/dbt/manifest/v6.json'
To fix the failing tests, I think we need to update the manifest file living here (either replace or add): https://github.com/dbt-labs/dbt-core/tree/main/schemas/dbt/manifest
Then, to fully resolve #5417, we should:
- update the
compatible_previous_versionsmethod, so that bothv4+v5are declared as backwards compatible forv6 - update the associated functional test
That piece doesn't need to happen in this PR, but it should happen before we close the issue and cut v1.2.0-rc1.
1 task
leahwicz
requested review from
gshank,
ChenyuLInx,
drewbanin,
emmyoop,
callum-mcdata and
jtcohen6
and removed request for
a team and
ChenyuLInx
leahwicz
changed the title
|
@emmyoop if you are good, I can merge this into the larger feature branch and see the tests pass |
emmyoop
approved these changes
Jul 5, 2022
5 tasks
emmyoop
added a commit
that referenced
this pull request
Jul 6, 2022
* wip * More support for ratio metrics * Formatting and linting * Fix unit tests * Support disabling metrics * mypy * address all TODOs * make pypy happy * wip * checkpoint * refactor, remove ratio_terms * flake8 and unit tests * remove debugger * quickfix for filters * Experiment with functional testing for 'expression' metrics * reformatting slightly * make file and mypy fix * remove config from metrics - wip * add metrics back to context * adding test changes * fixing test metrics * revert name audit * pre-commit fixes * add changelog * Bumping manifest version to v6 (#5430) * Bumping manifest version to v6 * Adding manifest file for tests * Reverting unneeded changes * Updating v6 * Updating test to add metrics field * Adding changelog * add v5 to backwards compatibility * Clean up test_previous_version_state, update for v6 (#5440) * Update test_previous_version_state for v6. Cleanup * Regenerate, rm breakpoint * Code checks * Add assertion that will fail when we bump manifest version * update tests to automatically tests all previous versions Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Callum McCann <cmccann51@gmail.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* wip * More support for ratio metrics * Formatting and linting * Fix unit tests * Support disabling metrics * mypy * address all TODOs * make pypy happy * wip * checkpoint * refactor, remove ratio_terms * flake8 and unit tests * remove debugger * quickfix for filters * Experiment with functional testing for 'expression' metrics * reformatting slightly * make file and mypy fix * remove config from metrics - wip * add metrics back to context * adding test changes * fixing test metrics * revert name audit * pre-commit fixes * add changelog * Bumping manifest version to v6 (dbt-labs#5430) * Bumping manifest version to v6 * Adding manifest file for tests * Reverting unneeded changes * Updating v6 * Updating test to add metrics field * Adding changelog * add v5 to backwards compatibility * Clean up test_previous_version_state, update for v6 (dbt-labs#5440) * Update test_previous_version_state for v6. Cleanup * Regenerate, rm breakpoint * Code checks * Add assertion that will fail when we bump manifest version * update tests to automatically tests all previous versions Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Callum McCann <cmccann51@gmail.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5417
Description
Bumping manifest version to 6 and fixing tests to merge into the
metricsPR #5027Checklist
changie newto create a changelog entry