Include py.typed in MANIFEST.in #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables packages that install dbt-core from pypi to use mypy.
|
@panasenco Thanks for the PR! Would you just mind opening an issue to associate with it? The description you included above is sufficient |
Done! #5737 |
leahwicz
added
the
ready_for_review
leahwicz
approved these changes
Sep 7, 2022
|
Re-triggering Snyk CI |
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
This enables packages that install dbt-core from pypi to use mypy.
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
This enables packages that install dbt-core from pypi to use mypy.
josephberni
pushed a commit
to Gousto/dbt-core
that referenced
this pull request
Sep 16, 2022
This enables packages that install dbt-core from pypi to use mypy.
bneijt
added a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Jun 23, 2023
add noop and warn tests improve tests rename tests add view dropping test add unmanaged schema test make tests more dry Delete tmp.csv Manage schemas is optional Add --target-path as a CLI option. (dbt-labs#5402) Include py.typed in MANIFEST.in (dbt-labs#5703) This enables packages that install dbt-core from pypi to use mypy. wip: move manage logic to separate command Add manage command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables packages that install dbt-core from pypi to use mypy.
Resolves #5737
Description
Currently when developing a dbt adapter and installing dbt-core with pip, I get errors like the following when trying to run mypy:
This is because the file py.typed is not included in the package uploaded to pypi.
The PR aims to include the file in the official dbt-core package to allow type checking in packages that depend on it.
I tested a local install and the file
py.typedis now included in thedbtfolder.Checklist
changie newto create a changelog entry