[CT-1154] [Bug] Adapter test bool_or contains reserved keyword

[sdebruyn]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The test fixture for the adapter test bool_or contains the reserved keyword key which might fail in some adapters (as it does in the one for SQL Server)

Expected Behavior

Tests should not use commonly reserved keywords for their column names

Steps To Reproduce

Implement the bool_or test in your adapter in a database engine where key is reserved (e.g. SQL Server)

Relevant log output

('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near the keyword 'key'. (156) (SQLMoreResults)")

Environment

No response

Which database adapter are you using with dbt?

other (mention it in "Additional Context")

Additional Context

dbt-sqlserver

[dbeatty10]

Thanks for reporting this @sdebruyn!

Which test(s) are failing on key being a reserved keyword?

Is it fixture_bool_or? Or something else?

[sdebruyn]

Hi @dbeatty10 that's indeed the one. I fixed that in the linked PR.