Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1239] [Feature] Allow partitions in external tables to be supplied as a list #5929

Closed
3 tasks done
pgoslatara opened this issue Sep 25, 2022 · 1 comment · Fixed by #5930
Closed
3 tasks done
Assignees
Labels
enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors

Comments

@pgoslatara
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Partitions in external tables can be supplied as a list (currently a name and data type are the minimum requirements).

Describe alternatives you've considered

Supplying a list of partitions with name and data_type values is superfluous, especially the data_type as this is not used. While specifying the partitions in this way works, it is not a great user experiences.

Who will this benefit?

Users of the dbt-external-tables package that have a Spark/Databricks connection.

Are you interested in contributing this feature?

Yes.

Anything else?

Background can be found in this comment on a PR for dbt-external-tables.

@pgoslatara pgoslatara added enhancement New feature or request triage labels Sep 25, 2022
@github-actions github-actions bot changed the title [Feature] Allow partitions in external tables to be supplied as a list [CT-1239] [Feature] Allow partitions in external tables to be supplied as a list Sep 25, 2022
@lostmygithubaccount
Copy link
Contributor

hi @pgoslatara, thanks for opening this issue and the corresponding PR to fix! we'll get that reviewed and get back to you with any requested changes through the PR

@leahwicz leahwicz added the help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants