Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing partitions in external table to be a list #5930

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Allowing partitions in external table to be a list #5930

merged 2 commits into from
Oct 12, 2022

Conversation

pgoslatara
Copy link
Contributor

@pgoslatara pgoslatara commented Sep 25, 2022 •
edited
Loading

resolves #5929

Description

Allow partitions in external tables to be a list of values. Currently both name and data_type keys are required for each column. This PR on dbt-external-tables` seeks to simplify specifying partitions for Spark/Databricks connections.

Checklist

@pgoslatara pgoslatara requested a review from a team as a code owner September 25, 2022 19:16
@cla-bot cla-bot bot added the cla:yes label Sep 25, 2022
@pgoslatara pgoslatara mentioned this pull request Sep 25, 2022
Merged
3 tasks
@lostmygithubaccount lostmygithubaccount added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Sep 27, 2022
@pgoslatara pgoslatara requested a review from a team as a code owner September 29, 2022 19:19
@emmyoop emmyoop removed the ok_to_test label Oct 6, 2022
ChenyuLInx
ChenyuLInx approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @pgoslatara Thanks for adding this!!!

@ChenyuLInx ChenyuLInx merged commit 6de1d29 into dbt-labs:main Oct 12, 2022
@jtcohen6 jtcohen6 added this to the v1.4 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@gshank gshank Awaiting requested review from gshank gshank is a code owner automatically assigned from dbt-labs/core-team

@lostmygithubaccount lostmygithubaccount Awaiting requested review from lostmygithubaccount lostmygithubaccount was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

[CT-1239] [Feature] Allow partitions in external tables to be supplied as a list
6 participants
@pgoslatara @ChenyuLInx @gshank @emmyoop @jtcohen6 @lostmygithubaccount