[CT-1350] Clean up string formatting

[emmyoop]

Describe the feature

Clean up the strings in dbt-core.

When we originally mass formatted our code with black, it caused some weird formatting that does not matter to Python but is not how it should be.

Examples:

dbt-core/core/dbt/adapters/base/impl.py

Lines 583 to 585 in 9b84b6e

	raise NotImplementedException(
	"`list_relations_without_caching` is not implemented for this " "adapter!"
	)

dbt-core/core/dbt/config/project.py

Lines 670 to 672 in 9b84b6e

	raise RuntimeException(
	f"Could not find selector named {name}, expected one of " f"{list(self.selectors)}"
	)

Searching the code for " f" finds many. The first example is harder to find as there are legitimate parts of the code with empty strings. It is still doable however.

Describe alternatives you've considered

Doing it as we touch these areas of code.

Who will this benefit?

Anyone looking at the code who is irked by this formatting.

Are you interested in contributing this feature?

No response

Anything else?

No response

[mhoss2008]

Hi

[luke-bassett]

Can I help with this one?

[luke-bassett]

I think this command finds all the files that contain cases that match the examples in the first comment on this issue (with a few false positives):

fd '.py$' | xargs grep -Ei '(.*"\s+".*)|(.*"\s+f".*)' | awk '{print $1}' | sort | uniq | sed -E 's/(.*):/\1/'

./core/dbt/adapters/base/impl.py
./core/dbt/clients/_jinja_blocks.py
./core/dbt/config/project.py
./core/dbt/context/base.py
./core/dbt/context/providers.py
./core/dbt/contracts/connection.py
./core/dbt/contracts/graph/manifest.py
./core/dbt/contracts/graph/unparsed.py
./core/dbt/contracts/results.py
./core/dbt/events/functions.py
./core/dbt/events/types.py
./core/dbt/exceptions.py
./core/dbt/graph/cli.py
./core/dbt/graph/graph.py
./core/dbt/graph/selector.py
./core/dbt/logger.py
./core/dbt/parser/base.py
./core/dbt/parser/generic_test_builders.py
./core/dbt/parser/schemas.py
./core/dbt/parser/sources.py
./core/dbt/task/base.py
./core/dbt/task/compile.py
./core/dbt/task/freshness.py
./core/dbt/task/init.py
./core/dbt/task/runnable.py
./core/dbt/tests/util.py
./core/dbt/utils.py
./plugins/postgres/dbt/adapters/postgres/connections.py
./tests/functional/artifacts/expected_manifest.py
./tests/functional/configs/test_disabled_model.py
./tests/functional/deprecations/test_deprecations.py
./tests/functional/duplicates/test_duplicate_analysis.py
./tests/functional/duplicates/test_duplicate_macro.py
./tests/functional/duplicates/test_duplicate_model.py

[luke-bassett]

Working on this one for the hackathon

[eve-johns]

Working on this one for the hackathon

+1

[emmyoop]

@luke-bassett script is a great way to go! The " " case has a lot more false positives. Feel free to do this in two iterations - once for f-strings and once for plain string.

[luke-bassett]

Looks like @eve-johns has covered f-strings. This command still has a couple false positives, but fewer.

fd '.py$' | xargs grep -Ei '.*".*"\s+".*".*' | awk '{print $1}' | sort | uniq | sed -E 's/(.*):/\1/' 

I'm making the changes now.

[eve-johns]

Ah I didn't noticed there are also plain strings problem. Trying regx

[github-actions]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

[github-actions]

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.