Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a snapshot succeeds, LogSnapshotResult shows result.status when it should show result.message #7583

Closed
jtcohen6 opened this issue May 10, 2023 · 0 comments · Fixed by #8524
Closed

When a snapshot succeeds, LogSnapshotResult shows result.status when it should show result.message #7583

jtcohen6 opened this issue May 10, 2023 · 0 comments · Fixed by #8524
Assignees
@gshank
Labels
bug Something isn't working logging Medium Severity bug with minor impact that does not have resolution timeframe requirement regression
Milestone
v1.6.x

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented May 10, 2023 •
edited by graciegoheen

This was actually regression in 1.4.latest, similar to #6250. The fix was 37a5d7c.

$ dbt snapshot
14:16:43  Running with dbt=1.6.0-a1
...
14:16:44  1 of 1 OK snapshotted dbt_jcohen.my_snap ....................................... [success in 0.10s]

14:18:22  Running with dbt=1.4.6
...
14:18:24  1 of 1 OK snapshotted dbt_jcohen.my_snap ....................................... [success in 0.19s]

14:18:40  Running with dbt=1.3.4
...
14:18:41  1 of 1 OK snapshotted dbt_jcohen.my_snap ....................................... [INSERT 0 1 in 0.16s]

Let's fix for main, and backport to 1.6 latest + 1.5.latest + 1.4.latest
@jtcohen6 jtcohen6 added this to the v1.5.x milestone May 10, 2023
@jtcohen6 jtcohen6 modified the milestones: v1.5.x, v1.6.x Jul 31, 2023
@jtcohen6 jtcohen6 mentioned this issue Aug 11, 2023
Closed
2 tasks
@gshank gshank mentioned this issue Aug 30, 2023
Merged
4 tasks
@graciegoheen graciegoheen added the Medium Severity bug with minor impact that does not have resolution timeframe requirement label Aug 30, 2023
@graciegoheen graciegoheen added the bug Something isn't working label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshank gshank

Labels
bug Something isn't working logging Medium Severity bug with minor impact that does not have resolution timeframe requirement regression
Projects
None yet
Milestone
v1.6.x
4 participants
@gshank @peterallenwebb @jtcohen6 @graciegoheen