Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3555] Add detect artifact changes workflow #9385

Closed
1 task done
Tracked by #9099
MichelleArk opened this issue Jan 16, 2024 · 0 comments · Fixed by #9553
Closed
1 task done
Tracked by #9099

[CT-3555] Add detect artifact changes workflow #9385

MichelleArk opened this issue Jan 16, 2024 · 0 comments · Fixed by #9553
Assignees
Labels
artifacts repo ci/cd Testing and continuous integration for dbt-core + adapter plugins

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Jan 16, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

We should detect whether a PR makes changes to an existing artifact schema, and fail CI if this is the case. https://github.com/marketplace/actions/prevent-file-change might do the trick!

Or, if we don't want to use an (overly-complex) public action, could do something manually:

  • check which files changed, and fail if any of those are modified
  • allow new files in dbt/artifacts

Acceptance criteria

  • CI fails if any file is modified in dbt/artifacts
  • failure message provides details
  • CI failure should either: not block merge, or is made to pass by setting a label (e.g. artifact_minor_upgrade)

Future work could be only failing the check if breaking changes are introduced. Until then, we can manually inspect the changes and merge on red if the change is deemed safe.

Additionally, tests in dbt/artifacts should provide signal as to whether a breaking change is made to an existing artifact because existing upgrade/downgrade logic would fail.

Impact to Other Teams

N/A - CI work in dbt-core

@github-actions github-actions bot changed the title Fix schema-check.yml workflow [CT-3555] Fix schema-check.yml workflow Jan 16, 2024
@MichelleArk MichelleArk added artifacts repo ci/cd Testing and continuous integration for dbt-core + adapter plugins labels Jan 16, 2024
@MichelleArk MichelleArk changed the title [CT-3555] Fix schema-check.yml workflow [CT-3555] Add detect artifact changes workflow Jan 25, 2024
@martynydbt martynydbt assigned QMalcolm and aranke and unassigned QMalcolm Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifacts repo ci/cd Testing and continuous integration for dbt-core + adapter plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants