Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved queries should always include relation spec (database.schema.alias), and respect generate_x_name macros #9534

Closed
Tracked by #9116
jtcohen6 opened this issue Feb 7, 2024 · 2 comments · Fixed by #9794
Assignees
Labels
Impact: SL Refinement Maintainer input needed semantic Issues related to the semantic layer

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 7, 2024

We should:

  • always include NodeRelation objects for each export (including database, schema_name, alias)
  • resolve the database / schema_name / alias with respect to generate_x_name macros (possibly by calling this method)

Testing Considerations:

Will need a migration from previously saved manifests.
Needs to be non-breaking change to artifacts.

Considerations:

May not be able to backport these.

Discussion Summarization:

  • Might need to refactor generate_x_name functions to be usable outside of initial parsing
  • Might not be able to migrate existing manifests, i.e. they won't get regenerated until reparsed
@jtcohen6 jtcohen6 added Refinement Maintainer input needed semantic Issues related to the semantic layer Impact: SL tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Feb 7, 2024
@martynydbt martynydbt added this to the v1.8 milestone Feb 8, 2024
@graciegoheen graciegoheen removed the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Feb 21, 2024
@martynydbt
Copy link

Proposal that this is not required for 1.8

@martynydbt martynydbt modified the milestones: v1.8, v1.9 Mar 11, 2024
@martynydbt martynydbt assigned aranke and MichelleArk and unassigned MichelleArk Mar 12, 2024
@aranke
Copy link
Member

aranke commented Mar 18, 2024

Update from estimation discussion:

  1. We can potentially avoid modifying artifacts by only adding the NodeRelation object to the export internal object that is not written to disk.
  2. Investigate whether this approach will satisfy A/C of resolving the database / schema_name / alias regarding generate_x_name macros.
  3. Document feasibility of writing NodeRelation to artifacts if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: SL Refinement Maintainer input needed semantic Issues related to the semantic layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants