Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primary_key to manifest #10096

Merged
merged 9 commits into from
May 10, 2024
Merged

Add primary_key to manifest #10096

merged 9 commits into from
May 10, 2024

Conversation

dave-connors-3
Copy link
Contributor

resolves #9824

Problem

This PR writes out the output of ModelNode.infer_primary_keys() to the manifest as a top level primary_key object.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@dave-connors-3 dave-connors-3 requested review from a team as code owners May 6, 2024 22:57
@dave-connors-3 dave-connors-3 requested review from heysweet and removed request for a team May 6, 2024 22:57
@cla-bot cla-bot bot added the cla:yes label May 6, 2024
@github-actions github-actions bot added the community This PR is from a community member label May 6, 2024
@dave-connors-3 dave-connors-3 added artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking and removed community This PR is from a community member labels May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.20%. Comparing base (84cc540) to head (446517a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10096      +/-   ##
==========================================
- Coverage   88.23%   88.20%   -0.04%     
==========================================
  Files         181      181              
  Lines       22787    22805      +18     
==========================================
+ Hits        20107    20115       +8     
- Misses       2680     2690      +10     
Flag Coverage Δ
integration 85.61% <100.00%> (+0.03%) ⬆️
unit 62.69% <73.68%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dave-connors-3 dave-connors-3 changed the title Add pk to manifest Add primary_key to manifest May 7, 2024
Copy link
Contributor

@heysweet heysweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline with Dave, supportive of singular primary_key if that makes more sense in the data context!

@MichelleArk
Copy link
Contributor

Artifact Schema Check should pass once dbt-labs/schemas.getdbt.com#39 is merged

@MichelleArk MichelleArk merged commit 8fe7d65 into main May 10, 2024
63 checks passed
@MichelleArk MichelleArk deleted the add-pk-to-manifest branch May 10, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialize inferred primary key in manifest.json
3 participants