Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Schema Check path for 1.6.latest #10347

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Fix Schema Check path for 1.6.latest #10347

merged 2 commits into from
Jun 20, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jun 20, 2024 •
edited
Loading

Problem

Artifact schema check fails due to double slash in path.

Solution

Fix path to be valid.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner June 20, 2024 16:06
@emmyoop emmyoop requested review from aranke and VersusFacit and removed request for a team June 20, 2024 16:06
@cla-bot cla-bot bot added the cla:yes label Jun 20, 2024
@emmyoop emmyoop changed the title fix path Fix Schema Check path for 1.6.latest Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jun 20, 2024
aranke
aranke approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@emmyoop emmyoop merged commit 48033a8 into 1.6.latest Jun 20, 2024
53 checks passed
@emmyoop emmyoop deleted the er/1.6-fix-artifact-check branch June 20, 2024 17:28
@aranke aranke mentioned this pull request Jul 12, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranke aranke aranke approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit is a code owner automatically assigned from dbt-labs/guild-oss-tooling

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emmyoop @aranke