Fix casing comparisons on dbt-created relations (#1555) #1558
Conversation
When dbt creates a relation in the db, add a special flag When checking a node name match: - if that flag is present and quoting is disabled, do a lowercase compare - otherwise remain case sensitive
There was a problem hiding this comment.
This looks good to me! This definitely fixes #1555, though I also am unable to reproduce #1557. That's ok, let's merge this as-is.
My only feedback is around the edges here: i think we'll need to update the spark plugin too? https://github.com/fishtown-analytics/dbt-spark/blob/master/dbt/adapters/spark/relation.py
Can you think of any other changes outside of the dbt-core codebase that would be required here? Like to new plugin setup script maybe?
|
I just checked and (contrary to my initial assumption) we shouldn't need to update the adapter plugin script, the script assumes you don't need to override |
|
Third party plugins that override |
|
ok, that's good. Let's merge this PR, then tackle dbt-spark separately. I'll make an issue over there to re-pin to 0.14.0 and can include this change in the description |
Fixes #1555
This might fix #1557 - hard to say as I couldn't figure out how to reproduce this one. I agree it's probably related though.
When dbt creates a relation in the db, add a special flag to the relation (defaults to False)
When checking a node name match: