Add "tags" and "meta" properties to exposure schema #3405
Conversation
There was a problem hiding this comment.
I have not included any changes that would enable selection of exposures using tags, a la
dbt ls --resource-type exposure --select tag:marketingbut I would be open to adding these to the PR if that is desired.
No need: this just works.
$ dbt ls --resource-type exposure --select tag:my_test_tag
exposure:my_project.my_test_exposure
I have also not altered anything in the docs server that would enable visualization there and not sure I'm qualified to do that work 😀
The meta properties show up just fine for exposures, and I believe we'd only need to change one line to get tags to show up too. It's just a matter of removing the part that says exclude="['tags']". Is that a change you'd be up to contribute? If so, could you open a new (stub) issue and new PR over in the dbt-docs repo?
In any case, this change LGTM. Thanks so much for opening the issue, owning the contribution, and seeing this get over the finish line!
| @@ -725,6 +722,7 @@ def same_url(self, old: 'ParsedExposure') -> bool: | |||
|
|
|||
| def same_contents(self, old: Optional['ParsedExposure']) -> bool: | |||
| # existing when it didn't before is a change! | |||
| # metadata/tags changes are not "changes" | |||
There was a problem hiding this comment.
👍 Agree with this.
Someday we may want to revisit the logic here (should a change to depends_on count?), but in a world where users run -m state:modified+ in CI, I don't think an exposure marked modified would even alter behavior there.
Sure thing! |
resolves #3404
Description
This PR enables users to use the
tagsandmetaproperties on exposures, in the exact same way they would with other resources. Given the "read-only" nature of exposures, the main use case is around enabling more metadata to be added to exposures, to make them a more authoritative record of data products.I have not included any changes that would enable selection of exposures using tags, a la
dbt ls --resource-type exposure --select tag:marketingbut I would be open to adding these to the PR if that is desired.I have also not altered anything in the docs server that would enable visualization there and not sure I'm qualified to do that work 😀
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.