Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3961] Enable cataloging of unlogged Postgres tables #3993

Conversation

samlader
Copy link
Contributor

@samlader samlader commented Oct 3, 2021

Description

Resolves #3961

  • Updated Postgres catalog macro to include unlogged tables
  • Tests for checking that unlogged tables appear in catalog

This is my first contribution to dbt. I would appreciate guidance on any additional changes I can make to improve this PR. 馃檪

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented Oct 3, 2021

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @samlader

@samlader
Copy link
Contributor Author

samlader commented Oct 3, 2021

I have now signed the CLA 馃檪

@samlader samlader changed the title [#3961] Update catalog macro & add tests [#3961] Enable cataloging of unlogged Postgres tables Oct 3, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samlader Thanks for the contribution, and for adding a great integration test!

This change looks just about good to ship. Could you add yourself to the list of Contributors? I've also added the ok to test label, so the rest of the Postgres integration suite should run on your next commit.

CHANGELOG.md Outdated Show resolved Hide resolved
@@ -36,7 +36,7 @@
{%- endfor -%}
)
and not pg_is_other_temp_schema(sch.oid) -- not a temporary schema belonging to another session
and tbl.relpersistence = 'p' -- [p]ermanent table. Other values are [u]nlogged table, [t]emporary table
and tbl.relpersistence in ('p', 'u') -- [p]ermanent table or [u]nlogged table. Exclude [t]emporary tables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@jtcohen6
Copy link
Contributor

jtcohen6 commented Oct 5, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Oct 5, 2021
@cla-bot
Copy link

cla-bot bot commented Oct 5, 2021

The cla-bot has been summoned, and re-checked this pull request!

@samlader samlader requested a review from jtcohen6 October 5, 2021 19:34
@jtcohen6 jtcohen6 merged commit 91b43f7 into dbt-labs:develop Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable cataloging unlogged postgres tables
2 participants