Use stricter RFC3339 time #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
approved these changes
Dec 1, 2021
9 tasks
leahwicz
pushed a commit
that referenced
this pull request
Dec 2, 2021
4 tasks
leahwicz
added a commit
that referenced
this pull request
Dec 2, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RFC3339 is a subset† in the umbrella of ISO8601. This change makes sure all our timestamps are in UTC and are denoted with the military indicator
Z.example timestamp:
2021-12-01T21:33:53.239614Zformat string:
'%Y-%m-%dT%H:%M:%S.%fZ'† It's not actually a subset even though it's generally stricter. There are some exceptions, but I've chosen to make sure our time stamps are both valid RFC3339 and ISO8601 for maximum compatibility. Specifically, the
Tdelimiter is allowed to be a space in RFC3339 but not in other ISO8601 standards so this chooses to continue to useT.Checklist
CHANGELOG.mdand added information about my change