Fix test deprecation warnings #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
requested changes
Jan 7, 2022
There was a problem hiding this comment.
=====487 passed, 2 skipped, 3263 warnings in 307.59s (0:05:07) =====
to
===== 487 passed, 2 skipped in 304.79s (0:05:04) =====
😍 😍
LGTM but I think any test changes we make should run with the test all label to make sure to catch anything weird with python versions / systems before we merge in.
gshank
force-pushed
the
test_deprecation_warnings
branch
from
248b165
to
2ba0df8
Compare
emmyoop
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3988
Description
Fix warnings that we see at the end of tests (from pytest). Two networkx deprecation warnings were fixed by using different functions, as recommended. The LegacyVersion deprecation warning was trapped in our semver.py package. The warnings caused by jinja use of 'soft_unicode' instead of 'soft_str' were suppresed in a pytest.ini file.
Checklist
CHANGELOG.mdand added information about my change