Ensure meta is both at node top level and in node.config. Fix snapshots with schema config. #4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
requested review from
ChenyuLInx and
iknox-fa
and removed request for
a team
gshank
requested review from
emmyoop,
jtcohen6 and
nathaniel-may
and removed request for
ChenyuLInx and
iknox-fa
|
Thrilled that these look like quick fixes! Two quick meta notes (hah):
|
emmyoop
approved these changes
Feb 17, 2022
CHANGELOG.md
Outdated
| @@ -33,6 +33,7 @@ Contributors: | |||
| - Restore previous log level (DEBUG) when a test depends on a disabled resource. Still WARN if the resource is missing ([#4594](https://github.com/dbt-labs/dbt-core/issues/4594), [#4647](https://github.com/dbt-labs/dbt-core/pull/4647)) | |||
| - Add project name validation to `dbt init` ([#4490](https://github.com/dbt-labs/dbt-core/issues/4490),[#4536](https://github.com/dbt-labs/dbt-core/pull/4536)) | |||
| - Support click versions in the v7.x series ([#4681](https://github.com/dbt-labs/dbt-core/pull/4681)) | |||
| - Fix bug causing empty node level meta, snapshot config errors ([#4459](https://github.com/dbt-labs/dbt-core/issues/4459), [#4726](https://github.com/dbt-labs/dbt-core/pull/4726)) | |||
There was a problem hiding this comment.
Per @jtcohen6's comment this should be moved to a 1.0.3 section.
timle2
pushed a commit
to timle2/dbt-core
that referenced
this pull request
Feb 21, 2022
…ts with schema config. (dbt-labs#4726) * Do not overwrite node.meta with empty patch.meta * Restore config_call_dict in snapshot node transform * Test for snapshot with schema file config * Test for meta in both toplevel node and node config
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4459, #4693
Description
This fixes a bug in schema file config processing, where an empty meta overwrote the root level meta. It also fixes a bug in snapshot schema config handling, where the snapshot SQL file config was lost.
Checklist
CHANGELOG.mdand added information about my change