Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add space before justification periods #4744

Merged
merged 5 commits into from Mar 22, 2022
Merged

Add space before justification periods #4744

merged 5 commits into from Mar 22, 2022

Conversation

joellabes
Copy link
Contributor

resolves #4737

Description

From the hard-to-select

03:48:20  1 of 1 OK loaded seed file dbt_jlabes.stg_server_farm_cities.................... [INSERT 4 in 6.58s]

to the easy-to-select

03:48:20  1 of 1 OK loaded seed file dbt_jlabes.stg_server_farm_cities ................... [INSERT 4 in 6.58s]

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@joellabes joellabes requested a review from a team February 18, 2022 03:51
@joellabes joellabes requested a review from a team as a code owner February 18, 2022 03:51
@cla-bot cla-bot bot added the cla:yes label Feb 18, 2022
@joellabes joellabes requested a review from a team as a code owner February 18, 2022 03:52
@joellabes
Copy link
Contributor Author

It looks like the error is

ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/opt/hostedtoolcache/Python/3.10.2/x64/lib/python3.10/site-packages/markupsafe/__init__.py)

I dont think this is me - any ideas?

@joellabes
Copy link
Contributor Author

Maybe this is it: #4745

ChenyuLInx
ChenyuLInx approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, for the pipeline issue I think you just need to rebase main again

leahwicz
leahwicz approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@leahwicz leahwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joel!

@gshank gshank merged commit 5e68192 into main Mar 22, 2022
@gshank gshank deleted the feat/4737-space-before-dot-justification branch March 22, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@leahwicz leahwicz leahwicz approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
4 participants
@joellabes @ChenyuLInx @leahwicz @gshank