Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch all requests exceptions to retry #4865

Merged
merged 2 commits into from Mar 15, 2022
Merged

catch all requests exceptions to retry #4865

merged 2 commits into from Mar 15, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 15, 2022

resolves #4849

Description

  1. Catch all exceptions from Requests by catching just requests.exceptions.RequestException instead of individual requests exceptions since they all inherit from RequestException
  2. Fire a new event to track the exception that we are catching for future tracking
  3. Update relevant tests

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@emmyoop emmyoop requested a review from a team March 15, 2022 15:52
@emmyoop emmyoop requested review from a team as code owners March 15, 2022 15:52
@cla-bot cla-bot bot added the cla:yes label Mar 15, 2022
@emmyoop emmyoop added the backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch label Mar 15, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop requested review from nathaniel-may and gshank and removed request for a team March 15, 2022 16:18
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@emmyoop emmyoop merged commit 5b01cc0 into main Mar 15, 2022
@emmyoop emmyoop deleted the er/ct-352-deps-retry branch March 15, 2022 16:57
@github-actions
Copy link
Contributor

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-4865-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 5b01cc0c222fc899ace9585554cb535571003056
# Push it to GitHub
git push --set-upstream origin backport-4865-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-4865-to-1.0.latest.

emmyoop added a commit that referenced this pull request Mar 15, 2022
* catch all requests exceptions to retry

* add changelog
emmyoop added a commit that referenced this pull request Mar 16, 2022
* catch all requests exceptions to retry (#4865)
* catch all requests exceptions to retry

* add changelog

* fixed pre-1.1 serialization issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-352] Catch all Requests Exception on Deps Install and Retry
2 participants