Convert --version tests to pytest #5026
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tests/unit/basic/test_version.py
Outdated
| @@ -0,0 +1,630 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
I placed this file under tests/unit/basic, since it's only explicitly testing the get_version_information function from version.py. There were no existing unit tests, so I'm not sure what the structure here should be.
There was a problem hiding this comment.
Good question. The old unit tests were all in one directory, and we don't have such a large number that it was much of an issue. So I'd be inclined to do the same for the converted tests, i.e. not put them in subdirectories of 'unit'. It feels like separating them out into subdirectories would just make them harder to find.
stu-k
requested review from
ChenyuLInx and
gshank
and removed request for
a team
tests/unit/basic/test_version.py
Outdated
| @@ -0,0 +1,630 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
Good question. The old unit tests were all in one directory, and we don't have such a large number that it was much of an issue. So I'd be inclined to do the same for the converted tests, i.e. not put them in subdirectories of 'unit'. It feels like separating them out into subdirectories would just make them harder to find.
Convert --version tests to pytest
Convert --version tests to pytest
resolves #5024
Description
Converted old
--versionunit tests topytestChecklist