Ct-65 metrics names with spaces #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
jtcohen6
approved these changes
Apr 27, 2022
| @classmethod | ||
| def validate(cls, data): | ||
| super(UnparsedMetric, cls).validate(data) | ||
| if "name" in data and " " in data["name"]: |
There was a problem hiding this comment.
In #4572, Joel offers:
- Motivation: Using metric names as column names. This will indeed vary by database!
- Expectation:
[_A-Za-z](I might say[a-z0-9_], as long as the numeric digit isn't first)
IMO spaces are the most disagreeable, even more than special characters. In any case, it looks like the logic here will be easy to extend if we decide to limit valid metric names to, e.g., alphanumeric characters and underscores. We'll want to incorporate opinions from the future maintainer(s) of the dbt-metrics package. For now, I'm happy with what you've got here!
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
* Convert existing metrics test * add non-failing test for names with spaces * Raise ParsingException if metrics name contains spaces * Remove old metrics tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4572
Description
Adds validation to UnparsedMetric class to ensure the metric name does not contain spaces
Checklist
changie newto create a changelog entry