Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the Makefile to use the default installed Python version instead of py38 for local testing #5269

Merged
merged 3 commits into from
May 19, 2022

Conversation

jwills
Copy link
Contributor

@jwills jwills commented May 18, 2022

resolves #5257

This is a pretty simple string substitution PR, changing up all instances of py38 to py in the Makefile, to support running with the user's local default python version instead of always requiring Python 3.8.

Checklist

@jwills jwills requested a review from a team as a code owner May 18, 2022 16:51
@jwills jwills requested review from gshank and emmyoop May 18, 2022 16:51
@cla-bot cla-bot bot added the cla:yes label May 18, 2022
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gshank gshank merged commit ae62f57 into dbt-labs:main May 19, 2022
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request May 20, 2022
…ad of py38 for local testing (dbt-labs#5269)

* Setting up an env var to use to override the tox python variable used for local dev

* Switch over to py-based tox envs instead of the py38 ones to be friendly to dbt-core devs who don't work at dbt Labs

* changie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-653] [Feature] Allow running unit/integration tests locally with any supported Python version
2 participants