feature/deps-regex-semver #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added
Team:Language
ready_for_review
Alexstriker360
approved these changes
Jun 15, 2022
leahwicz
suggested changes
Jun 30, 2022
core/dbt/semver.py
Outdated
| @@ -95,7 +95,7 @@ def from_version_string(cls, version_string): | |||
|
|
|||
| if not match: | |||
| raise dbt.exceptions.SemverException( | |||
| 'Could not parse version "{}"'.format(version_string) | |||
| '"{}" is not a valid semantic version.'.format(version_string) | |||
There was a problem hiding this comment.
Suggested change
| '"{}" is not a valid semantic version.'.format(version_string) | |
| f'"{version_string}" is not a valid semantic version.' |
There was a problem hiding this comment.
Added this change in the most recent commit. Thanks!
core/dbt/semver.py
Outdated
| @@ -427,6 +427,15 @@ def resolve_to_specific_version(requested_range, available_versions): | |||
| return max_version_string | |||
|
|
|||
|
|
|||
| def semver_regex_versioning(versions: List[str]) -> bool: | |||
There was a problem hiding this comment.
Is this just for testing? Can we move it into the test file if that's the case?
There was a problem hiding this comment.
This is just for testing the various version types. I moved it into the testing file as that does make a lot more sense 馃槃
leahwicz
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
LGTM! Thanks @fivetran-joemarkiewicz for the contribution 馃帀
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* feature/deps-regex-semver * pre-commit fixes * applying review updates
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5201
Description
In this PR I incorporate the suggested regular expression (RegEx) to check a SemVer string for when
dbt depsis invoked. Truth be told, when breaking out this expression, there wasn't too much difference from what was included previously. Please let me know if I missed anything.In addition to the above, I updated the error that is shown when the versioning does not fit within the new regex rules. This error message will be descriptive to show users that the version most likely needs to be modified.
Finally, I added unit testing to ensure all variations of the valid versions shown here are truly valid, and that all variations of the invalid versions shown here are truly invalid. Please note, I ended up creating a new function to simply test if the version triggered the error message upon invoking the
from_version_stringfunction. Please let me know if this was not needed and there was just a unit test I was simply missing! This is my first attempt at unit tests so happy to modify where needed! 馃槃CLI Output
Based off these changes, if the version provided for a package does not match the regex rules then we should see a clearer error. See below for my validation of the error message
Checklist
鈽濓笍 I don't think this is needed, but please let me know and I can if that is required.
changie newto create a changelog entry