Fix/fix quotes behaviour in snapshots #5389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeatty10
added
snapshots
jtcohen6
added
Team:Adapters
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* fix: add quotes to relation * fix: add quotes correctly * chore: reset main.py * chore: reset main.py from master * chore: newline * chore: changie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2975
Description
At least on Snowflake, using the check_columns='all' strategy for snapshots does not properly take into account quotes in column names. With this PR the quotes are added automatically if the adapter supports them. I think it should work on all the databases since the name of the column is taken directly from the database itself.
Checklist
changie newto create a changelog entry