Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-679] flip logic around reset color detection #5394

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

darin-reify
Copy link
Contributor

@darin-reify darin-reify commented Jun 17, 2022

  • this makes is so that the reset color code won't be appended to logs
    when use-colors is false.

resolves #5288

Checklist

- this makes is so that the reset color code won't be appended to logs
  when `use-colors` is false.
@darin-reify darin-reify requested a review from a team June 17, 2022 20:00
@darin-reify darin-reify requested a review from a team as a code owner June 17, 2022 20:00
@darin-reify darin-reify requested review from stu-k and gshank June 17, 2022 20:00
@cla-bot
Copy link

cla-bot bot commented Jun 17, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @darin-reify

@darin-reify darin-reify requested a review from a team as a code owner June 17, 2022 20:00
@cla-bot
Copy link

cla-bot bot commented Jun 17, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @darin-reify

@gshank
Copy link
Contributor

gshank commented Jun 22, 2022

Darin: Can you sign one of the CLAs which is linked from https://docs.getdbt.com/docs/contributing/contributor-license-agreements? We can get this processed once that's done. Thanks!

@darin-reify
Copy link
Contributor Author

Darin: Can you sign one of the CLAs which is linked from https://docs.getdbt.com/docs/contributing/contributor-license-agreements? We can get this processed once that's done. Thanks!

hey there, sorry was just crossing my t's and dotting my i's. i've signed the agreement!

@gshank
Copy link
Contributor

gshank commented Jun 22, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Jun 22, 2022
@cla-bot
Copy link

cla-bot bot commented Jun 22, 2022

The cla-bot has been summoned, and re-checked this pull request!

core/dbt/events/functions.py Outdated Show resolved Hide resolved
@jtcohen6 jtcohen6 added Team:Language ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Jun 28, 2022
@gshank gshank merged commit d63ad4c into dbt-labs:main Jun 29, 2022
@darin-reify darin-reify deleted the ct-679 branch July 1, 2022 22:25
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-679] [Bug] when shelling out to dbt, disabling colored output still prints out the reset color code
3 participants