Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: remove duplicate key checking #5403

Merged
merged 2 commits into from Jun 23, 2022
Merged

Conversation

jeremyyeo
Copy link
Contributor

@jeremyyeo jeremyyeo commented Jun 22, 2022

Temporarily resolves #5331 and #5268

Description

Fallback PR to remove duplicate key checking which is causing some bugs in 1.2.0a1.

Checklist

@jeremyyeo jeremyyeo requested a review from a team as a code owner June 22, 2022 20:23
@cla-bot cla-bot bot added the cla:yes label Jun 22, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor

@leahwicz leahwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just looks like a revert of https://github.com/dbt-labs/dbt-core/pull/5146/files so LGTM!

@gshank gshank merged commit 1cfc085 into main Jun 23, 2022
@gshank gshank deleted the fix/revert-duplicate-key-checking branch June 23, 2022 19:24
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
* remove duplicate key checking

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-722] DuplicateYamlKeyException needs to be warning, not (broken) exception
3 participants