Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jinja2 v3 upgrade #5465

Merged
merged 4 commits into from Jul 19, 2022
Merged

jinja2 v3 upgrade #5465

merged 4 commits into from Jul 19, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jul 12, 2022 •
edited

resolves #4748

Description

Upgrade from Jinja2==2.11.3 to Jinja2==3.1.2.

Nothing in the Jinja2 changelogs seems to be an issue, integration tests all pass and local testing worked without issue.

Checklist

@cla-bot cla-bot bot added the cla:yes label Jul 12, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@r-richmond r-richmond mentioned this pull request Jul 15, 2022
Closed
@emmyoop emmyoop changed the title naive jinja2 v3 upgrade jinja2 v3 upgrade Jul 19, 2022
@emmyoop emmyoop marked this pull request as ready for review July 19, 2022 19:18
@emmyoop emmyoop requested a review from a team as a code owner July 19, 2022 19:18
jtcohen6
jtcohen6 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're planning a nice long beta for v1.3, anyway. Let's give it a try :)

@emmyoop emmyoop merged commit a1ee348 into main Jul 19, 2022
@emmyoop emmyoop deleted the er/ct-258-jinja3 branch July 19, 2022 21:16
@jtcohen6
Copy link
Contributor

Could we also now remove our upper bound on MarkupSafe, which we put in place earlier this year due to incompatibility with Jinja2?

@emmyoop
Copy link
Member Author

emmyoop commented Jul 20, 2022 •
edited

Probably but I can test it to be sure it won't cause issues.

Looks like Jinja2 requires MarkUpSafe >= 2.0 so we should also bump the lower bound of it in addition to removing the upper bound.

#5506

@kaxil kaxil mentioned this pull request Aug 9, 2022
Closed
@lostmygithubaccount lostmygithubaccount mentioned this pull request Aug 31, 2022
Closed
3 tasks
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
@emmyoop
jinja2 v3 upgrade (dbt-labs#5465)
4893424 
* update version

* ignore mypy for now

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@leahwicz leahwicz leahwicz approved these changes

@stu-k stu-k Awaiting requested review from stu-k stu-k was automatically assigned from dbt-labs/core-group

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-258] [Spike] Upgrade to Jinja3?
3 participants
@emmyoop @jtcohen6 @leahwicz